Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove software tools section #604

Closed
wants to merge 19 commits into from
Closed

Remove software tools section #604

wants to merge 19 commits into from

Conversation

ItayZiv
Copy link
Contributor

@ItayZiv ItayZiv commented Apr 5, 2020

Remove software tools and split up the tools into the most fitting location. Not 100% sure about the locations...

fixes #505

@ItayZiv ItayZiv mentioned this pull request Apr 5, 2020
@AustinShalit AustinShalit requested a review from sciencewhiz April 6, 2020 05:21
@Daltz333
Copy link
Member

Merge conflicts need to get fixed.

@ItayZiv
Copy link
Contributor Author

ItayZiv commented Apr 15, 2020

I believe they are fixed now

AustinShalit
AustinShalit previously approved these changes Apr 19, 2020
@AustinShalit
Copy link
Member

Approved. Because this is a restructure, I'd like to get another reviewer to make sure that this is the direction we want to move in. In general we try to avoid restructures but I think that in this case it makes sense.

@sciencewhiz

Daltz333
Daltz333 previously approved these changes May 1, 2020
@ItayZiv ItayZiv dismissed stale reviews from Daltz333 and AustinShalit via 2c0e18a May 3, 2020 17:21
Copy link
Member

@AustinShalit AustinShalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge master into this branch

@ItayZiv
Copy link
Contributor Author

ItayZiv commented May 10, 2020

Merged

AustinShalit and others added 3 commits May 10, 2020 17:29
…ools

# Conflicts:
#	source/docs/software/advanced-controls/trajectories/pathweaver/images/pathweaver-9.png
#	source/docs/software/robot-simulation/images/vscode-loading-extension.png
#	source/docs/software/robotbuilder/advanced/images/am-14u4-6in-mecanum-upgrade.jpg
#	source/docs/software/robotbuilder/advanced/images/command-run-commands-1.png
#	source/docs/software/robotbuilder/advanced/images/command-run-commands-2.png
#	source/docs/software/robotbuilder/advanced/images/command-run-commands-3.png
#	source/docs/software/robotbuilder/advanced/images/command-run-commands-4.png
#	source/docs/software/robotbuilder/advanced/images/command-run-commands-5.png
#	source/docs/software/robotbuilder/advanced/images/driving-with-mecanum-1.png
#	source/docs/software/robotbuilder/introduction/images/driving-with-mecanum-1.png
@ItayZiv ItayZiv requested a review from AustinShalit June 6, 2020 20:26
ItayZiv added 4 commits June 22, 2020 18:38
…ools

# Conflicts:
#	.tx/config
#	source/docs/software/dashboards/robot-simulation/images/vs-build-tools.png
#	source/docs/software/dashboards/robotbuilder/advanced/images/am-14u4-6in-mecanum-upgrade.png
#	source/docs/software/dashboards/robotbuilder/introduction/images/robotbuilder-created-code-2.png
#	source/docs/software/robotbuilder/advanced/images/am-14u4-6in-mecanum-upgrade.jpg
#	source/docs/software/robotbuilder/advanced/robotbuilder-drive-mecanum.rst
Copy link
Member

@Daltz333 Daltz333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could PathWeaver be moved as a section in Advanced Controls? It breaks the navigation flow when using the "next buttons".

image

Additionally, add a link in the root TOC under Software Tools.

We have decided to keep the Software Tools section, but instead branch out the dashboards and move the root location of the characterization and following tools into Advanced Controls.

frc-characterization should also be moved as a root under "Advanced Controls" with a link in the main TOC under Software Tools.

@Starlight220 Starlight220 mentioned this pull request Jul 7, 2020
15 tasks
@Daltz333
Copy link
Member

@ItayZiv stale?

@Daltz333
Copy link
Member

Daltz333 commented Jun 6, 2021

Closed as superceded

@Daltz333 Daltz333 closed this Jun 6, 2021
@ItayZiv ItayZiv deleted the remove-software-tools branch December 2, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Tools section; put tools in their respective areas
3 participants