Move GRIP to wpilib-tools #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daltz333
reviewed
Apr 2, 2020
|
I'll remove it for now, who originally wrote the documentation, since adding stuff like references to the NT publishing, and I have a few other questions. |
|
GRIP is maintained by the WPI (not WPILib) team. Consider it supported for right now. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AustinShalit
reviewed
Apr 4, 2020
| @@ -5,5 +5,4 @@ Vision Processing | |||
| :maxdepth: 2 | |||
|
|
|||
| introduction/index | |||
There was a problem hiding this comment.
I think we need something in the vision section that mentions GRIP. Can we add a ¶ to the intro?
|
Hi @ItayZiv. @sciencewhiz suggested yesterday in the issue that it might actually be better to leave GRIP in vision processing and remove the tools section: #505 (comment). Do you want to close this PR and open a new one that does that instead? |
|
Made a new PR, #604. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #505.
WIP because I also want to fix a few stuff in the docs, like references to Eclipse and some of the docs seem to have been written before GRIP was released and mention that.