-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unvendor Yarn; favor Corepack for installation #243
Conversation
According to the Yarn documentation, Yarn no longer needs to be bundled with a project, but rather, installing Yarn ought to be done using [Corepack](https://yarnpkg.com/corepack), which is shipped in modern Node versions. This commit removes the Yarn binary from the repo and updates the installation instructions in the README to match.
Looks like corepack support is still pending in |
Devs will still need to run |
* ci: run `corepack enable` as part of prepare * chore(ci): do redundant setup-node step before checkout to enable yarn v4 before deps install - makes nodejs version `lts/*` explicit in ci workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of dislike the hacks we have to do here. It makes the GitHub workflow files longer and more complicated than they need to be. It's true Corepack is the recommended way to install Yarn, but it doesn't mean that the yarnPath
method is deprecated. So I'm inclined to not do this and keep the current way. Then again, the downside to the current approach is that projects are obligated to use the same version of Yarn as in the template, which doesn't seem completely necessary either. Sigh...
Agreed. I still find it less ugly and less objectively bad than redundantly checking in the entire minified yarn cjs file without additional integrity-checking in every repo... |
Yeah, that's true. Okay, I'm convinced. ✅ |
@mcmire ping |
According to the Yarn documentation, Yarn no longer needs to be bundled with a project, but rather, installing Yarn ought to be done using Corepack, which is shipped in modern Node versions. This commit removes the Yarn binary from the repo and updates the installation instructions in the README to match.
Examples
(None)