Unvendor Yarn; favor Corepack for installation (#243)

According to the Yarn documentation, Yarn no longer needs to be bundled with a project, but rather, installing Yarn ought to be done using [Corepack](https://yarnpkg.com/corepack), which is shipped in modern Node versions. This commit removes the Yarn binary from the repo and updates the installation instructions in the README to match. --------- Co-authored-by: legobeat <[email protected]>
MetaMask · Jun 6, 2024 · 03f796f · 03f796f
1 parent b14503d
commit 03f796f
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 900 deletions.
diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml
@@ -8,11 +8,17 @@ jobs:
     name: Prepare
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version: 'lts/*'
+      - name: Install Yarn
+        run: corepack enable
+      - uses: actions/checkout@v4
+      - name: Use Node.js and install dependencies
+        uses: actions/setup-node@v4
+        with:
+          node-version: 'lts/*'
           cache: 'yarn'
       - name: Install Yarn dependencies
         run: yarn --immutable
@@ -23,11 +29,17 @@ jobs:
     needs:
       - prepare
     steps:
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 'lts/*'
+      - name: Install Yarn
+        run: corepack enable
       - uses: actions/checkout@v4
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version: 'lts/*'
           cache: 'yarn'
       - run: yarn --immutable --immutable-cache
       - run: yarn build
@@ -45,11 +57,17 @@ jobs:
     needs:
       - prepare
     steps:
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 'lts/*'
+      - name: Install Yarn
+        run: corepack enable
       - uses: actions/checkout@v4
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version: 'lts/*'
           cache: 'yarn'
       - run: yarn --immutable --immutable-cache
       - run: yarn lint
@@ -76,6 +94,12 @@ jobs:
       matrix:
         node-version: [18.x, 20.x]
     steps:
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Install Yarn
+        run: corepack enable
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
@@ -101,6 +125,12 @@ jobs:
       matrix:
         node-version: [18.x, 20.x]
     steps:
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Install Yarn
+        run: corepack enable
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4