chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo #24930

HowardBraham · 2024-05-31T01:16:48Z

Description

Updates Yarn to the latest version: 4.2.2
Removes the yarn-*.cjs files from our repo (see this discussion about how these 2.6MB files shouldn't be committed)
Now using corepack enable in CircleCI

This is very similar to MetaMask/metamask-module-template#243

Related issues

Similar: MetaMask/metamask-module-template#243

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-31T01:17:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

legobeat · 2024-05-31T01:39:17Z

.circleci/config.yml

@@ -354,6 +354,7 @@ jobs:
    executor: node-browsers-small
    steps:
      - run: *shallow-git-clone
+      - run: sudo corepack enable


Does it with with just corepack enable sans sudo?

Nope, this is what happens without sudo https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/84179/workflows/a00c10d8-5c25-4604-9332-5a71d51e512f/jobs/3025527

codecov · 2024-05-31T01:45:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.79%. Comparing base (5f22357) to head (39fd66a).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24930   +/-   ##
========================================
  Coverage    65.79%   65.79%           
========================================
  Files         1364     1364           
  Lines        54315    54315           
  Branches     14126    14126           
========================================
  Hits         35732    35732           
  Misses       18583    18583

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-05-31T02:11:26Z

Builds ready [e8bc321]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (660 ± 484 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	210	102	29	14
		domContentLoaded	9	111	19	22	10
		load	59	3161	660	1008	484
		domInteractive	9	111	19	22	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

mcmire

Nice!

metamaskbot · 2024-05-31T16:10:53Z

Builds ready [176984d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (107 ± 123 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	101	79	9	4
		domContentLoaded	9	12	10	1	0
		load	42	1219	107	255	123
		domInteractive	9	12	10	1	0

metamaskbot · 2024-05-31T16:33:07Z

Builds ready [39fd66a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (232 ± 256 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	120	88	11	5
		domContentLoaded	9	30	14	6	3
		load	44	2025	232	533	256
		domInteractive	9	30	14	6	3

legobeat · 2024-06-01T03:04:01Z

@HowardBraham This broke some GitHub Actions workflows..
Fixed in:

chore(ci): use yarn v4 in GitHub Actions #24973

HowardBraham added the team-contributor-experience label May 31, 2024

HowardBraham self-assigned this May 31, 2024

HowardBraham force-pushed the update-yarn branch from b3ee5fa to e8bc321 Compare May 31, 2024 01:23

HowardBraham requested review from davidmurdoch, legobeat and mcmire May 31, 2024 01:37

HowardBraham marked this pull request as ready for review May 31, 2024 01:38

HowardBraham requested review from kumavis and a team as code owners May 31, 2024 01:38

legobeat reviewed May 31, 2024

View reviewed changes

HowardBraham force-pushed the update-yarn branch from e8bc321 to 84e29ad Compare May 31, 2024 02:13

legobeat previously approved these changes May 31, 2024

View reviewed changes

mcmire previously approved these changes May 31, 2024

View reviewed changes

HowardBraham dismissed stale reviews from mcmire and legobeat via 176984d May 31, 2024 05:17

legobeat previously approved these changes May 31, 2024

View reviewed changes

HowardBraham added 2 commits May 31, 2024 08:58

chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo

b882613

fixed the mv2 merge

39fd66a

HowardBraham dismissed legobeat’s stale review via 39fd66a May 31, 2024 15:58

HowardBraham force-pushed the update-yarn branch from 176984d to 39fd66a Compare May 31, 2024 15:58

HowardBraham requested review from mcmire and legobeat May 31, 2024 15:59

mcmire approved these changes May 31, 2024

View reviewed changes

legobeat approved these changes May 31, 2024

View reviewed changes

legobeat merged commit 0b0bf11 into develop May 31, 2024
77 checks passed

legobeat deleted the update-yarn branch May 31, 2024 20:24

github-actions bot locked and limited conversation to collaborators May 31, 2024

benjisclowder added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024

HowardBraham added contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo #24930

chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo #24930

HowardBraham commented May 31, 2024 •

edited by github-actions bot

Loading

github-actions bot commented May 31, 2024

legobeat May 31, 2024

HowardBraham May 31, 2024

codecov bot commented May 31, 2024 •

edited

Loading

metamaskbot commented May 31, 2024

mcmire left a comment

metamaskbot commented May 31, 2024

metamaskbot commented May 31, 2024

legobeat commented Jun 1, 2024

chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo #24930

chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo #24930

Conversation

HowardBraham commented May 31, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented May 31, 2024

legobeat May 31, 2024

Choose a reason for hiding this comment

HowardBraham May 31, 2024

Choose a reason for hiding this comment

codecov bot commented May 31, 2024 • edited Loading

Codecov Report

metamaskbot commented May 31, 2024

mcmire left a comment

Choose a reason for hiding this comment

metamaskbot commented May 31, 2024

metamaskbot commented May 31, 2024

legobeat commented Jun 1, 2024

HowardBraham commented May 31, 2024 •

edited by github-actions bot

Loading

codecov bot commented May 31, 2024 •

edited

Loading