[wpiutil] Add ManagedStatic #7739
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This import from LLVM adds a wpi_shutdown() function to explicitly destroy all managed static instances.
github-actions
bot
added
component: wpiutil
ThadHouse
reviewed
Jan 27, 2025
PeterJohnson
commented
Jan 27, 2025
Comment on lines
+71
to
+72
| /// IMPORTANT: it's only safe to call wpi_shutdown() in single thread, | ||
| /// without any other threads executing LLVM APIs. |
There was a problem hiding this comment.
Remove this comment since it's thread safe now.
PeterJohnson
commented
Jan 27, 2025
| } | ||
| } | ||
|
|
||
| void ManagedStaticBase::destroy() const { |
There was a problem hiding this comment.
Add a comment about this not being thread-safe if called individually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This import from LLVM adds a wpi_shutdown() function to explicitly destroy all managed static instances.