-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a new project for building a strongly named version #11
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks man
Common.Build.props
Outdated
<PropertyGroup> | ||
<Version>7.1.3</Version> | ||
<GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
<Authors>Saeed Farahi Mohassel</Authors> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @bothzoli,
Please also include your name as authors :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, I really appreciate this 😊
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<None Include="$(ProjectDir)..\README.md" Pack="true" PackagePath="\"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice hack!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought, there must be a better way of doing this other than duplicating the README file :)
libc.eventbus.snk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bothzoli
May I ask how you created this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, you can find all info here.
There's a tool in the VS developer console called sn.exe
that can create signing key pairs.
I just ran sn.exe -k libc.eventbus.snk
and took that file.
I was thinking about setting up a GitHub workflow action that would do build validation before merging a PR. |
c0f6dd5
to
a7cbb20
Compare
f998e5f
to
81d568e
Compare
81d568e
to
efbb139
Compare
Okay, I created the workflow as well, you can take a look here. Hopefully you'll have access, but posting a screenshot here in any case: It would also be possible to add a corresponding workflow badge to the I think the workflow should automatically be called for subsequent PRs, but I'm not 100% sure TBH. Let me know what you think 😊 |
With this PR a new project
libc.eventbus.strongname
was created.This project references the source files from
libc.eventbus
but when built will also sign the created DLLs.This allows the
libc.eventbus.strongname
nuget package to be used where a strongly named assembly is required.The common project properties are moved to the
Common.Build.props
file.Solution files were added to the solution.
The duplicate
REAMDE.md
file was removed.A signing key was added to the solution.
A minor version bump was applied (since there are no code changes).
Resolves: #10