Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new project for building a strongly named version #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bothzoli
Copy link
Contributor

@bothzoli bothzoli commented Feb 13, 2025

With this PR a new project libc.eventbus.strongname was created.
This project references the source files from libc.eventbus but when built will also sign the created DLLs.
This allows the libc.eventbus.strongname nuget package to be used where a strongly named assembly is required.

The common project properties are moved to the Common.Build.props file.
Solution files were added to the solution.
The duplicate REAMDE.md file was removed.
A signing key was added to the solution.
A minor version bump was applied (since there are no code changes).

Resolves: #10

Copy link
Owner

@sfmohassel sfmohassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man

<PropertyGroup>
<Version>7.1.3</Version>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Authors>Saeed Farahi Mohassel</Authors>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @bothzoli,
Please also include your name as authors :)

Copy link
Contributor Author

@bothzoli bothzoli Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I really appreciate this 😊

</PropertyGroup>

<ItemGroup>
<None Include="$(ProjectDir)..\README.md" Pack="true" PackagePath="\"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hack!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought, there must be a better way of doing this other than duplicating the README file :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bothzoli
May I ask how you created this file?

Copy link
Contributor Author

@bothzoli bothzoli Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, you can find all info here.
There's a tool in the VS developer console called sn.exe that can create signing key pairs.
I just ran sn.exe -k libc.eventbus.snk and took that file.

@bothzoli
Copy link
Contributor Author

I was thinking about setting up a GitHub workflow action that would do build validation before merging a PR.
What do you think about that?
I may be able to put together something in the coming days.

@bothzoli bothzoli force-pushed the feature/strong-name branch 4 times, most recently from c0f6dd5 to a7cbb20 Compare February 13, 2025 23:37
@bothzoli bothzoli closed this Feb 14, 2025
@bothzoli bothzoli reopened this Feb 14, 2025
@bothzoli bothzoli force-pushed the feature/strong-name branch 5 times, most recently from f998e5f to 81d568e Compare February 14, 2025 00:21
@bothzoli bothzoli force-pushed the feature/strong-name branch from 81d568e to efbb139 Compare February 14, 2025 00:22
@bothzoli
Copy link
Contributor Author

bothzoli commented Feb 14, 2025

Okay, I created the workflow as well, you can take a look here. Hopefully you'll have access, but posting a screenshot here in any case:

image

It would also be possible to add a corresponding workflow badge to the README.md (this one is now linked to my repo):
libc.eventbus-ci

I think the workflow should automatically be called for subsequent PRs, but I'm not 100% sure TBH.

Let me know what you think 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strong naming assemblies
2 participants