Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong naming assemblies #10

Open
bothzoli opened this issue Feb 10, 2025 · 5 comments · May be fixed by #11
Open

Strong naming assemblies #10

bothzoli opened this issue Feb 10, 2025 · 5 comments · May be fixed by #11

Comments

@bothzoli
Copy link
Contributor

Hello @sfmohassel,

I would like to use your library in a project that needs strongly named assemblies.
Would you be interested in providing a strongly signed version of this Nuget?
I would be happy to help setting that up similarly to CSharpFunctionalExtensions.

@bothzoli
Copy link
Contributor Author

Hi @sfmohassel,

turned out that I needed the strong named package quite fast so I ended up adding it from a fork (see here), I hope you don't mind.

If you are okay with these changes, I'm happy to merge them back and set you as package owner etc.

@sfmohassel
Copy link
Owner

Dear @bothzoli
Thank you for the initiative! I humbly accepted the offer. Thank you for the contribution

@bothzoli
Copy link
Contributor Author

Hello @sfmohassel,

Thank you, I will create a PR in the coming days for the strongname project.

@bothzoli
Copy link
Contributor Author

Hi @sfmohassel,
Please see #11 for merging back the changes related to strong naming.

@sfmohassel
Copy link
Owner

Hi @bothzoli
Already added minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants