MX: hook up mxfp8 and mxfp4 CUTLASS kernels to MXLinear #1713
+180
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1713
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Feb 14, 2025
Summary: 1. add a kernel choice setting to `MXLinearConfig` to choose between emulated gemm and CUTLASS gemm 2. respect the setting in the torch.mm op override 3. numerical tests to match emulated vs real e2e activations/weights/grads Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1d12e235c90ad3f46335654d62d3376efc035d84 ghstack-comment-id: 2657958104 Pull Request resolved: #1713
vkuzo
added a commit
that referenced
this pull request
Feb 14, 2025
Summary: 1. add a kernel choice setting to `MXLinearConfig` to choose between emulated gemm and CUTLASS gemm 2. respect the setting in the torch.mm op override 3. numerical tests to match emulated vs real e2e activations/weights/grads Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1d12e235c90ad3f46335654d62d3376efc035d84 ghstack-comment-id: 2657958104 Pull Request resolved: #1713
vkuzo
added
the
topic: improvement
vkuzo
added a commit
that referenced
this pull request
Feb 14, 2025
Summary: 1. add a kernel choice setting to `MXLinearConfig` to choose between emulated gemm and CUTLASS gemm 2. respect the setting in the torch.mm op override 3. numerical tests to match emulated vs real e2e activations/weights/grads Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9234dba200094da88c2d13bc20e198aa7ffb5af6 ghstack-comment-id: 2657958104 Pull Request resolved: #1713
drisspg
approved these changes
Feb 14, 2025
drisspg
reviewed
Feb 14, 2025
vkuzo
added a commit
that referenced
this pull request
Feb 14, 2025
Summary: 1. add a kernel choice setting to `MXLinearConfig` to choose between emulated gemm and CUTLASS gemm 2. respect the setting in the torch.mm op override 3. numerical tests to match emulated vs real e2e activations/weights/grads Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 55f72a0e0d18898c2f02fb2d88c537b382ed5a67 ghstack-comment-id: 2657958104 Pull Request resolved: #1713
vkuzo
added a commit
that referenced
this pull request
Feb 14, 2025
Summary: 1. add a kernel choice setting to `MXLinearConfig` to choose between emulated gemm and CUTLASS gemm 2. respect the setting in the torch.mm op override 3. numerical tests to match emulated vs real e2e activations/weights/grads Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 55f72a0e0d18898c2f02fb2d88c537b382ed5a67 ghstack-comment-id: 2657958104 Pull Request resolved: #1713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MXLinearConfigto choose betweenemulated gemm and CUTLASS gemm
activations/weights/grads
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: