MX: move block_size and elem_dtype into MXLinearConfig #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1689
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Feb 10, 2025
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 92913315b65e8b19a55bab3a51c54ed56c1bb4f4 ghstack-comment-id: 2649054194 Pull Request resolved: #1689
vkuzo
added
the
topic: improvement
drisspg
reviewed
Feb 10, 2025
| # TODO(future PR): refactor to make this cleaner | ||
| elem_dtype_weight_override: Optional[Any] = None | ||
| elem_dtype_grad_output_override: Optional[Any] = None | ||
|
|
||
| # If True, uses a custom triton kernel for fp4 dequantize | ||
| use_fp4_custom_triton_dequant_kernel: bool = False |
There was a problem hiding this comment.
you think that we will want to keep this public?
There was a problem hiding this comment.
unlikely, but IMO we can punt that until later
drisspg
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves
block_sizeandelem_dtypeintoMXLinearConfigand updates all callsites.Before
After
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: