Fix dry run logic #1921
Merged
Fix dry run logic #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/fix-dry-run-logic
branch
from
8b2832f
to
73578af
Compare
vihangm
approved these changes
May 27, 2024
…n bug Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/fix-dry-run-logic
branch
from
1311177
to
522fdd3
Compare
ddelnano
added a commit
that referenced
this pull request
May 28, 2024
…te (#1923) Summary: Remove dry_run inputs responsible for regbot dry runs to always execute I attempted to fix the bug where `--dry-run` is always passed to the `regbot` cli in the mirror workflows in #1921. That attempt unfortunatley did not work, so let's remove the input and the cli argument templating entirely. Running `regbot --dry-run` locally is an easy enough mechanism for testing the workflow logic. Relevant Issues: Precursor to fixing px-sock-shop (#1905) Type of change: /kind bug Test Plan: Expecting that the next run off main after this change will result in mirrored demo container images Signed-off-by: Dom Del Nano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix use of GitHub expression to fix image mirroring dry run logic
The version of the workflow on main always runs with
--dry-runprovided regardless of the input value. I thought that the 'else' case of a ternary could be omitted, but that was incorrect. The latest implementation aligns with the example in the GitHub docs.Relevant Issues: Precursor to fixing px-sock-shop (#1905)
Type of change: /kind bug
Test Plan: Updated based on the docs. Needs to be validated with a workflow run against a branch in the pixie-io org