Skip to content

Commit

Permalink
Remove dry_run inputs responsible for regbot dry runs to always execu…
Browse files Browse the repository at this point in the history
…te (#1923)

Summary: Remove dry_run inputs responsible for regbot dry runs to always
execute

I attempted to fix the bug where `--dry-run` is always passed to the
`regbot` cli in the mirror workflows in #1921. That attempt
unfortunatley did not work, so let's remove the input and the cli
argument templating entirely. Running `regbot --dry-run` locally is an
easy enough mechanism for testing the workflow logic.

Relevant Issues: Precursor to fixing px-sock-shop
(#1905)

Type of change: /kind bug

Test Plan: Expecting that the next run off main after this change will
result in mirrored demo container images

Signed-off-by: Dom Del Nano <[email protected]>
  • Loading branch information
ddelnano authored May 28, 2024
1 parent a2d61a3 commit 1f2d486
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/mirror_demos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
name: mirror-demos
on:
workflow_dispatch:
inputs:
dry_run:
description: 'Run the sync in dry-run mode'
required: false
default: false
type: boolean
permissions:
contents: read
jobs:
Expand Down Expand Up @@ -42,4 +36,4 @@ jobs:
shell: bash
run: |
cd scripts/regclient
regbot once ${{ github.event.inputs.dry_run && '--dry-run' || '' }} --config regbot_demos.yaml
regbot once --config regbot_demos.yaml
8 changes: 1 addition & 7 deletions .github/workflows/mirror_deps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
name: mirror-deps
on:
workflow_dispatch:
inputs:
dry_run:
description: 'Run the sync in dry-run mode'
required: false
default: false
type: boolean
permissions:
contents: read
jobs:
Expand Down Expand Up @@ -42,4 +36,4 @@ jobs:
shell: bash
run: |
cd scripts/regclient
regbot once ${{ github.event.inputs.dry_run && '--dry-run' || '' }} --config regbot_deps.yaml
regbot once --config regbot_deps.yaml

0 comments on commit 1f2d486

Please sign in to comment.