Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reload in saved_search spec as bug has been resolved #9396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/9396.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
test:
- Remove unnecessary reload in saved_search test. ([#9396](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9396))
3 changes: 0 additions & 3 deletions cypress/utils/apps/query_enhancements/saved.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,6 @@ export const setSearchConfigurations = ({

cy.getElementByTestId(`docTableHeaderFieldSort_${APPLIED_SORT}`).click();

// TODO: This reload shouldn't need to be here, but currently the sort doesn't always happen right away
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/9131
cy.reload();
cy.getElementByTestId('querySubmitButton').should('be.visible');
}
};
Expand Down
Loading