Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reload in saved_search spec as bug has been resolved #9396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Feb 15, 2025

Description

To workaround a bug, a reload was added. Now that the bug has been resolved, the reload no longer needs to be there.

Issues Resolved

closes #9131

Screenshot

image

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see saved_search.spec.js. Run the test spec.

Changelog

  • test: remove unnecessary reload in saved_search test.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (4d55b4d) to head (7f58fc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9396   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files        3817     3817           
  Lines       91860    91860           
  Branches    14551    14551           
=======================================
  Hits        56697    56697           
  Misses      31507    31507           
  Partials     3656     3656           
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.20% <ø> (ø)
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Query enhancement sorting with time index pattern does not work as expected.
2 participants