Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overwrite on upload artifact #9383

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build_and_test_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ jobs:
path: |
test/*/failure_debug/
test/*/screenshots/
overwrite: true

plugin-functional-tests:
name: Run plugin functional tests on ${{ matrix.name }}
Expand Down Expand Up @@ -423,6 +424,7 @@ jobs:
path: |
test/*/failure_debug/
test/*/screenshots/
overwrite: true

build-min-artifact-tests:
name: Build min release artifacts on ${{ matrix.name }}
Expand Down Expand Up @@ -535,6 +537,7 @@ jobs:
name: ${{ matrix.suffix }}-${{ env.VERSION }}
path: ./artifacts/target/${{ env.ARTIFACT_BUILD_NAME }}
retention-days: 1
overwrite: true

bwc-tests:
needs: [build-min-artifact-tests]
Expand Down Expand Up @@ -627,3 +630,4 @@ jobs:
./artifacts/bwc_tmp/test/cypress/screenshots/*
./artifacts/bwc_tmp/test/cypress/results/*
retention-days: 1
overwrite: true
14 changes: 10 additions & 4 deletions .github/workflows/cypress_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,15 @@ jobs:
# Dashboard tests with query enhanced - group 3
- group: 13
config: query_enhanced
test_location: source
test_location: source
# Dashboard tests with query enhanced - group 4
- group: 14
config: query_enhanced
test_location: source
# Dashboard tests with query enhanced - group 5
- group: 15
config: query_enhanced
test_location: source
test_location: source
container:
image: docker://opensearchstaging/ci-runner:ci-runner-rockylinux8-opensearch-dashboards-integtest-v2
options: --user 1001
Expand Down Expand Up @@ -282,14 +282,16 @@ jobs:
name: ftr-cypress-screenshots-${{ matrix.group }}
path: ${{ env.FTR_PATH }}/cypress/screenshots
retention-days: 1
overwrite: true

- name: Upload FT repo videos
uses: actions/upload-artifact@v4
if: always() && matrix.test_location == 'ftr'
if: failure() && matrix.test_location == 'ftr'
with:
name: ftr-cypress-videos-${{ matrix.group }}
path: ${{ env.FTR_PATH }}/cypress/videos
retention-days: 1
overwrite: true

- name: Upload FT repo results
uses: actions/upload-artifact@v4
Expand All @@ -298,6 +300,7 @@ jobs:
name: ftr-cypress-results-${{ matrix.group }}
path: ${{ env.FTR_PATH }}/cypress/results
retention-days: 1
overwrite: true

- name: Upload Dashboards screenshots
if: failure() && matrix.test_location == 'source'
Expand All @@ -306,14 +309,16 @@ jobs:
name: dashboards-cypress-screenshots-${{ matrix.group }}
path: cypress/screenshots
retention-days: 1
overwrite: true

- name: Upload Dashboards repo videos
uses: actions/upload-artifact@v4
if: always() && matrix.test_location == 'source'
if: failure() && matrix.test_location == 'source'
with:
name: dashboards-cypress-videos-${{ matrix.group }}
path: cypress/videos
retention-days: 1
overwrite: true

- name: Upload Dashboards repo results
uses: actions/upload-artifact@v4
Expand All @@ -322,6 +327,7 @@ jobs:
name: dashboards-cypress-results-${{ matrix.group }}
path: cypress/results
retention-days: 1
overwrite: true

add-comment:
needs: [cypress-tests]
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/cypress_workflow_with_s3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,19 +130,22 @@ jobs:
name: dashboards-cypress-screenshots-10
path: cypress/screenshots
retention-days: 1
overwrite: true

- name: Upload Dashboards repo videos
uses: actions/upload-artifact@v4
if: always()
if: failure()
with:
name: dashboards-cypress-videos-10
path: cypress/videos
retention-days: 1
overwrite: true

- name: Upload Dashboards repo results
uses: actions/upload-artifact@v4
if: always()
with:
name: dashboards-cypress-results-10
path: cypress/results
retention-days: 1
retention-days: 1
overwrite: true
4 changes: 3 additions & 1 deletion .github/workflows/release_cypress_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,12 @@ jobs:
name: release-osd-cypress-screenshots-${{ matrix.spec_group }}
path: ${{ env.OSD_PATH }}/cypress/screenshots
retention-days: 1
overwrite: true

- uses: actions/upload-artifact@v4
if: always()
if: failure()
with:
name: release-osd-cypress-videos-${{ matrix.spec_group }}
path: ${{ env.OSD_PATH }}/cypress/videos
retention-days: 1
overwrite: true
Loading