Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overwrite on upload artifact #9383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Maosaic
Copy link
Contributor

@Maosaic Maosaic commented Feb 13, 2025

Description

Enable overwrite on upload artifact

Issues Resolved

when upgrade actions/upload-artifact from v3 to v4, by default it disabled overwrite on upload artifact, which can break our CI action.

Run actions/upload-artifact@v4
/usr/bin/docker exec  67b6fe2ab6755c4ac4d8f3ce17062864e8c76474287aff42e172161441b98545 sh -c "cat /etc/*release | grep ^ID"
With the provided path, there will be 6 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Ref: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#overwriting-an-artifact

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (4d55b4d) to head (cdd5c85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9383      +/-   ##
==========================================
- Coverage   61.72%   61.71%   -0.01%     
==========================================
  Files        3817     3817              
  Lines       91860    91860              
  Branches    14551    14551              
==========================================
- Hits        56697    56695       -2     
- Misses      31507    31508       +1     
- Partials     3656     3657       +1     
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <ø> (-0.01%) ⬇️
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abbyhu2000
abbyhu2000 previously approved these changes Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repeat-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants