Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-core module and subworkflow mirdeep2 #6662

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Sep 18, 2024

This PR adds modules and a subworkflow associated with mirdeep2.

Part of the migration from local to nf-core modules in nf-core/smrnaseq#368 to match latest standards and improve quality.

Closes nf-core/smrnaseq#431

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@atrigila atrigila requested a review from a team as a code owner September 18, 2024 15:23
@atrigila atrigila requested review from Aratz and removed request for a team September 18, 2024 15:23
@atrigila
Copy link
Contributor Author

atrigila commented Sep 18, 2024

There is an issue with java.nio.channels.OverlappingFileLockException #6664 in the conda subworkflow test

@atrigila atrigila added the help wanted Extra attention is needed label Sep 18, 2024
@atrigila
Copy link
Contributor Author

The conda issue persists but, I will fix the new linting issues with the dev version of nf-core tools and nf-core modules lint --fix

@sateeshperi sateeshperi merged commit 757f60e into nf-core:master Sep 23, 2024
17 of 19 checks passed
@atrigila
Copy link
Contributor Author

Thank you @sateeshperi!

@atrigila atrigila deleted the mirdeep branch September 23, 2024 17:39
herpov pushed a commit to herpov/modules that referenced this pull request Oct 2, 2024
* first design mirdeep

* fix prettier

* fix linting

* reformat subworkflow structure

* fix linting

* allow paths to files or replace with 'none'

* fix linting

* capture unstable outputs in snapshot

* update meta

---------

Co-authored-by: Alexander Peltzer <[email protected]>
Co-authored-by: Sateesh_Peri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create nf-core mirdeep module
3 participants