feat(phone): Add unconfirmed to RecoveryPhoneManager
#18012
Merged
+118
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dschom
reviewed
Nov 13, 2024
| @@ -11,6 +11,12 @@ describe('RecoveryPhoneManager', () => { | |||
| let recoveryPhoneManager: RecoveryPhoneManager; | |||
| let db: AccountDatabase; | |||
|
|
|||
| const redisMock = { | |||
There was a problem hiding this comment.
Super small nit, we've been prefix with mock, so mockRedis would be consistent perhaps.
dschom
reviewed
Nov 13, 2024
| * @param code The SMS code associated with this user | ||
| * @returns The stored phone number data if found, or null if not found | ||
| */ | ||
| async getUnconfirmed(uid: string, code: string): Promise<any> { |
There was a problem hiding this comment.
Should it be Promise<{phoneNumber:string, isSetup:boolean, lookupData:Record<string, any>|null}> so it's symmetric?
dschom
reviewed
Nov 13, 2024
| lookupData: lookupData ? JSON.stringify(lookupData) : null, | ||
| }; | ||
|
|
||
| await this.redisClient.set(redisKey, JSON.stringify(data), 'EX', 600); |
dschom
reviewed
Nov 13, 2024
|
|
||
| @Injectable() | ||
| export class RecoveryPhoneManager { | ||
| private readonly redisPrefix = 'sms-attempt'; |
There was a problem hiding this comment.
Should this be hard coded? Maybe we need to pass in a config?
dschom
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-10346
Checklist
Other information (Optional)
I took a look at adding the
OtpManager(same one we use for password reset code), but we would need to refactor it a good bit to accept additional data needed for sms. To unblock other stuff, we can add that in a follow up.