task(recovery-phone): Create new phone number setup method #18007
+188
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
commented
Nov 13, 2024
| setup: boolean | ||
| ) { | ||
| // TODO: Provide real implementation FXA-10346 | ||
| console.log('TODO: implement storeUnconfirmed', { |
vbudhram
reviewed
Nov 13, 2024
| setup: boolean | ||
| ) { | ||
| // TODO: Provide real implementation FXA-10346 | ||
| console.log('TODO: implement storeUnconfirmed', { |
| } | ||
| } | ||
|
|
||
| const code = await this.otpCode.create(`${uid}:${phoneNumber}`); |
There was a problem hiding this comment.
I think we would want to use getCode?
There was a problem hiding this comment.
getCode is private. Seems like create is the public facing function.
@vbudhram I noticed this as well. It seem redundant to store the code twice; however, the |
…r setup method Because: - We want to be able to setup a new phone number This Commit: - Creates a recovery phone service - Stubs out storeUnconfirmed in RecoveryPhoneManager - Adds config for recovery phone service - Adds tests for recovery phone service - Adds new error type RecoveryNumberNotSupportedError - Public exposes generateCode on OtpManager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-10347
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Waiting on blocker to land, put a stub in place for now.