DOP-5197 #55
Merged
DOP-5197 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for site-links-display failed. Why did it fail? →
|
✅ Deploy Preview for git-changed-file-extension canceled.
|
❌ Deploy Preview for search-manifest-extension failed. Why did it fail? →
|
✅ Deploy Preview for populate-data-extension canceled.
|
✅ Deploy Preview for slack-deploy-extension canceled.
|
❌ Deploy Preview for redoc-extension failed. Why did it fail? →
|
✅ Deploy Preview for offline-snooty ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for persistence-module-ext canceled.
|
✅ Deploy Preview for redirects-and-publish-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for snooty-cache-extension canceled.
|
seungpark
commented
Jan 2, 2025
| const { bucketName, fileName } = readEnvConfigs({ | ||
| env: (environment.ENV as string) ?? '', | ||
| docsetEntry: (environment.DOCSET_ENTRY as DocsetsDocument) ?? {}, | ||
| // NOTE: prd and dotcomprd both read from pool.repos_branches |
There was a problem hiding this comment.
TODO: minor note to uncomment this after approval. wanted to leave this for logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the repos_branches collection within our pool db (or pool_test) with the correct path of the URL of the offline docs file.
Note: PR originally says a boolean flag, but to keep the front end pure, changed this to the actual URL of the docs. In dotcomstg or dotcomprd, these URL's have CDN configured to point to the correct bucket and path. This will only run in dotcomstg (for testing) and dotcomprd environments. (See note)
See full deploy log here
Above log has updated our
pooldb because it is running onprdenvironment, but this extension will not be run inprd- refer to note link above