Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5251: update projects route to include offline download url #48

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Jan 7, 2025

Ticket

DOP-5251

Notes

  • This route already exists on prod to get all the projects and corresponding branches https://snooty-data-api.mongodb.com/projects - Adding onto this route so this also returns the offline download URL for this each page. Currently in pool.repos_branches there is a test property under 'cloud-docs - master' branch for offlineUrl (generated by Netlify extension).
  • The proposal is that the front end will use this route to populate the modal for users to see available downloads
  • Since staging is Okta auth'ed, testing in staging / docs-qa will require an additional step, as you need to be okta-verified to make requests to the server

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@seungpark seungpark requested review from mmeigs and rayangler January 7, 2025 15:01
@@ -7,7 +7,7 @@ on:

jobs:
lint-and-test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was to mitigate this error for failed dependencies

@rayangler
Copy link
Collaborator

(Nit) Can we change the PR title to include context?

@seungpark seungpark changed the title DOP-5251 DOP-5251: update projects route to include offline download url Jan 7, 2025
@seungpark
Copy link
Collaborator Author

(Nit) Can we change the PR title to include context?

thanks for pointing that out! done

@seungpark seungpark merged commit c0da9a5 into main Jan 7, 2025
1 check passed
@seungpark seungpark deleted the DOP-5251 branch January 7, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants