Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow methods returning IIterable<T> to be used as synchronous generators #361
base: master
Are you sure you want to change the base?
Allow methods returning IIterable<T> to be used as synchronous generators #361
Changes from 5 commits
6dc6c18
d4f4f48
a2e9ae3
fc62916
adbe1bd
84affac
f58cdcb
7d038a6
0a19f62
3888b11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a way to keep a strong or weak reference to a class here, as well as a pointer. Maybe something similar to C++/WinRT's delegate implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
Func
accepts those arguments, it's already possible (e.g. calling a member function with a strong reference that is stored in theIIterable<T>
helper withwil::make_iterable_from_iterator(&Foo::Bar, get_strong())
. That doesn't work with weak references, but what would the semantics be if the weak pointer's object has been destroyed? ShouldFirst
return an empty iterator?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A member function pointer won't take a strong reference as argument directly via std::invoke/std::apply.
Good point reguarding weak references, lets just ignore that for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like std::invoke will try
(*arg).(*f)()
, I did not know that. Nothing to do here, then.