Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow methods returning IIterable<T> to be used as synchronous generators #361

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Allow methods returning IIterable<T> to be used as synchronous generators #361

wants to merge 10 commits into from

Commits on Sep 18, 2023

  1. Allow methods returning IIterable<T> to be used as synchronous genera… 

    …tors
    @Fulgen301
    Fulgen301 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6dc6c18 View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @Fulgen301
    Fulgen301 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d4f4f48 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Constrain the generator implementation to IIterator<T> and add 

    `wil::make_iterable_from_iterator` to create an `IIterable<T>` helper object

C++ coroutines can only be evaluated once, which doesn't fulfill
`IIterable<T>`'s requirement that it can return multiple independent iterators.
Thus the generator implementation is constrained to `IIterator<T>`, which may
only be evaluated once, and a helper method is added that returns an
`IIterable<T>` which creates a new generator instance every time an iterator
is requested.
    @Fulgen301
    Fulgen301 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a2e9ae3 View commit details
    Browse the repository at this point in the history

  2. Throw winrt::hresult_out_of_bounds when the iterator is at the end

    @Fulgen301
    Fulgen301 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fc62916 View commit details
    Browse the repository at this point in the history

  3. Add missing @cond / @endcond for wil::details

    @Fulgen301
    Fulgen301 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    adbe1bd View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge branch 'master' into user/Fulgen301/iiterable-generator

    @jonwis
    jonwis authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    84affac View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Rename make_iterable_from_iterator to make_iterable_from_generator 

    Co-authored-by: Duncan Horn <[email protected]>
    @Fulgen301 @dunhor
    Fulgen301 and dunhor authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f58cdcb View commit details
    Browse the repository at this point in the history

  2. Rename make_iterable_from_iterator to make_iterable_from_generator in… 

    … the test cases
    @Fulgen301
    Fulgen301 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7d038a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Merge branch 'master' into user/Fulgen301/iiterable-generator

    @dunhor
    dunhor authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    0a19f62 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge branch 'master' into user/Fulgen301/iiterable-generator

    @dunhor
    dunhor authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3888b11 View commit details
    Browse the repository at this point in the history