feat(react-charting): strongly type plotly schema and bug fixes #33621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 13, 2025
…microsoft/fluentui into user/atisjai/stronglyTypePlotly
AtishayMsft
changed the title
AtishayMsft
changed the title
krkshitij
approved these changes
Jan 20, 2025
Anush2303
reviewed
Jan 20, 2025
| import * as React from 'react'; | ||
| import { useTheme } from '@fluentui/react'; | ||
| import { IRefObject } from '@fluentui/react/lib/Utilities'; | ||
| import { DonutChart } from '../DonutChart/index'; | ||
| import { VerticalStackedBarChart } from '../VerticalStackedBarChart/index'; | ||
| import { PlotData, PlotlySchema } from './PlotlySchema'; | ||
| //import type { Data, Layout } from './PlotlySchema'; |
There was a problem hiding this comment.
We can remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The plotly schema is a dynamic object.
As the schema is so complex, it is prone to mis representation and unhandled failures.
New Behavior
All the unsupported definitions are removed to align with fluent charts.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/plotly.js/index.d.ts
Related Issue(s)