feat(declarative-chart): Support for Dashed line #33691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush2303
changed the base branch from
master
to
user/atisjai/stronglyTypePlotly
AtishayMsft
reviewed
Jan 20, 2025
| @@ -281,6 +281,9 @@ export const transformPlotlyJsonToVSBCProps = ( | |||
| const color = getColor(legend, colorMap, isDarkTheme); | |||
| mapXToDataPoints[x].lineData!.push({ | |||
| legend, | |||
| lineOptions: ['dot', 'dash', 'longdash', 'dashdot', 'longdashdot'].includes(series.line?.dash as Dash) | |||
| ? { strokeDasharray: '5', strokeLinecap: 'butt', strokeWidth: '2', lineBorderWidth: '4' } | |||
There was a problem hiding this comment.
lets use the same dash type as provided by plotly.
dot = dot representation and so on
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray
AtishayMsft
reviewed
Jan 21, 2025
| @@ -29,7 +29,7 @@ import { DataVizPalette, getNextColor } from '../../utilities/colors'; | |||
| import { GaugeChartVariant, IGaugeChartProps, IGaugeChartSegment } from '../GaugeChart/index'; | |||
| import { IGroupedVerticalBarChartProps } from '../GroupedVerticalBarChart/index'; | |||
| import { IVerticalBarChartProps } from '../VerticalBarChart/index'; | |||
| import { Layout, PlotlySchema, PieData, PlotData, SankeyData } from './PlotlySchema'; | |||
| import { Layout, PlotlySchema, PieData, PlotData, SankeyData, Dash } from './PlotlySchema'; | |||
There was a problem hiding this comment.
Could you address this also. #33621 (review)
AtishayMsft
reviewed
Jan 21, 2025
| @@ -470,6 +473,9 @@ export const transformPlotlyJsonToScatterChartProps = ( | |||
|
|
|||
| return { | |||
| legend, | |||
| lineOptions: ['dot', 'dash', 'longdash', 'dashdot', 'longdashdot'].includes(series.line?.dash as Dash) | |||
| ? { strokeDasharray: '5', strokeLinecap: 'butt', strokeWidth: '2', lineBorderWidth: '4' } | |||
| : {}, | |||
There was a problem hiding this comment.
also resolve the colormap pending comments
Anush2303
changed the base branch from
user/atisjai/stronglyTypePlotly
to
master
|
Closing this PR. Will create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No support for dashed line.
New Behavior
Related Issue(s)