Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshcircuitbreaker): supplement HealthyPanicThreshold property #12860

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(meshcircuitbreaker): supplement HealthyPanicThreshold property #12860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f06ae09
feat(meshcircuitbreaker): supplement HealthyPanicThreshold property
Icarus9913 Feb 17, 2025
89b9e1b
fix generated docs
Icarus9913 Feb 17, 2025
cb26a3c
unit test
Icarus9913 Feb 17, 2025
4dacc26
golden files
Icarus9913 Feb 17, 2025
d41656e
adjust envoy configurer
Icarus9913 Feb 18, 2025
0eb11fd
e2e
Icarus9913 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/common/v1alpha1/decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package v1alpha1

import (
"errors"
"fmt"

"github.com/shopspring/decimal"
"k8s.io/apimachinery/pkg/util/intstr"
Expand All @@ -14,6 +14,6 @@ func NewDecimalFromIntOrString(intOrString intstr.IntOrString) (decimal.Decimal,
case intstr.String:
return decimal.NewFromString(intOrString.String())
default:
return decimal.Zero, errors.New("invalid IntOrString")
return decimal.Zero, fmt.Errorf("invalid IntOrString '%s'", intOrString.String())
}
}
27 changes: 27 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9658,6 +9658,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -9969,6 +9978,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -10280,6 +10298,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down
27 changes: 27 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9658,6 +9658,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -9969,6 +9978,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -10280,6 +10298,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down
27 changes: 27 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9678,6 +9678,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -9989,6 +9998,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -10300,6 +10318,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down
27 changes: 27 additions & 0 deletions app/kumactl/cmd/install/testdata/install-crds.all.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,6 +1534,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -1845,6 +1854,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -2156,6 +2174,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down
27 changes: 27 additions & 0 deletions deployments/charts/kuma/crds/kuma.io_meshcircuitbreakers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -585,6 +594,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down Expand Up @@ -896,6 +914,15 @@ spec:
description: When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: |-
Allows to configure panic threshold for Envoy cluster. If not specified,
the default is 50%. To disable panic mode, set to 0%.
Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: |-
The time interval between ejection analysis sweeps. This can result in
Expand Down
39 changes: 39 additions & 0 deletions docs/generated/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4788,6 +4788,19 @@ components:
When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: >-
Allows to configure panic threshold for Envoy
cluster. If not specified,

the default is 50%. To disable panic mode, set to
0%.

Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: >-
The time interval between ejection analysis
Expand Down Expand Up @@ -5332,6 +5345,19 @@ components:
When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: >-
Allows to configure panic threshold for Envoy
cluster. If not specified,

the default is 50%. To disable panic mode, set to
0%.

Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: >-
The time interval between ejection analysis
Expand Down Expand Up @@ -5876,6 +5902,19 @@ components:
When set to true, outlierDetection configuration
won't take any effect
type: boolean
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: >-
Allows to configure panic threshold for Envoy
cluster. If not specified,

the default is 50%. To disable panic mode, set to
0%.

Either int or decimal represented as string.
x-kubernetes-int-or-string: true
interval:
description: >-
The time interval between ejection analysis
Expand Down
Loading
Loading