-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meshcircuitbreaker): supplement HealthyPanicThreshold property #12860
Open
Icarus9913
wants to merge
6
commits into
kumahq:master
Choose a base branch
from
Icarus9913:feat/wk/circuitbreaker-panic-threshold
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(meshcircuitbreaker): supplement HealthyPanicThreshold property #12860
Icarus9913
wants to merge
6
commits into
kumahq:master
from
Icarus9913:feat/wk/circuitbreaker-panic-threshold
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should supplement HealthyPanicThreshold property in MeshCircuitBreaker policy OutlierDetection section Signed-off-by: Icarus Wu <[email protected]>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
lukidzi
reviewed
Feb 20, 2025
return nil | ||
} | ||
|
||
func envoyPercent(intOrStr intstr.IntOrString) (*envoy_type.Percent, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move it to pkg/util/proto/types.go
? We have all the Envoy structures there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should supplement HealthyPanicThreshold property in MeshCircuitBreaker policy OutlierDetection section
Implementation information
Introduce a new
HealthyPanicThreshold
property for MeshCircuitBreaker policy, and its type is*intstr.IntOrString
just like what we did in MeshHealthCheck policyHealthyPanicThreshold
overwrite the MeshHealthCheck'sSupporting documentation
Fix #11704