Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshcircuitbreaker): supplement HealthyPanicThreshold property #12860

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Icarus9913
Copy link
Contributor

@Icarus9913 Icarus9913 commented Feb 17, 2025

Motivation

We should supplement HealthyPanicThreshold property in MeshCircuitBreaker policy OutlierDetection section

Implementation information

Introduce a new HealthyPanicThreshold property for MeshCircuitBreaker policy, and its type is *intstr.IntOrString just like what we did in MeshHealthCheck policy

  • unit test
  • e2e test
  • verify the MeshCircuitBreaker HealthyPanicThreshold overwrite the MeshHealthCheck's

Supporting documentation

Fix #11704

We should supplement HealthyPanicThreshold property in MeshCircuitBreaker policy OutlierDetection section

Signed-off-by: Icarus Wu <[email protected]>
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
@Icarus9913 Icarus9913 marked this pull request as ready for review February 20, 2025 03:45
@Icarus9913 Icarus9913 requested a review from a team as a code owner February 20, 2025 03:45
return nil
}

func envoyPercent(intOrStr intstr.IntOrString) (*envoy_type.Percent, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to pkg/util/proto/types.go ? We have all the Envoy structures there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce HealthyPanicThreshold for MeshCircuitBreaker policy
2 participants