Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): deduplicate dataplane inbounds by address and port combination #12760

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Feb 5, 2025

Motivation

We now can have multiple inbounds if multiple services select the same address and port, but we will generate Envoy resources only for one of these. We should deduplicate them on creation so that we don't have inbounds that don't correlate with Envoy resources. This can be also useful for GUI

@Automaat Automaat added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 5, 2025
@Automaat Automaat requested a review from a team as a code owner February 5, 2025 14:37
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Marcin Skalski <[email protected]>
Signed-off-by: Marcin Skalski <[email protected]>
…rom-pod

# Conflicts:
#	pkg/plugins/runtime/k8s/controllers/pod_controller_test.go
#	pkg/plugins/runtime/k8s/controllers/testdata/01.dataplane.yaml
@Automaat Automaat changed the title feat(kuma-cp): inbound name should be taken from pod instead of service feat(kuma-cp): deduplicate dataplane inbounds by address and port conmbination Feb 12, 2025
@Automaat Automaat changed the title feat(kuma-cp): deduplicate dataplane inbounds by address and port conmbination feat(kuma-cp): deduplicate dataplane inbounds by address and port combination Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant