Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): inbound name should be taken from pod instead of service #12783

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Feb 7, 2025

Motivation

At this moment we are taking inbound name from service port name. In order to get rid of kuma.io/service we need to take name from pod port name. Since we are not using name at the moment, it is safe to switch this.

@Automaat Automaat added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 7, 2025
@Automaat Automaat requested a review from a team as a code owner February 7, 2025 08:45
@Automaat Automaat requested review from jijiechen and slonka February 7, 2025 08:45
@Automaat
Copy link
Contributor Author

Automaat commented Feb 7, 2025

this extracts naming part from: #12760 as I am still looking into failing tests, and this should work now

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lobkovilya
Copy link
Contributor

btw it's used here, but I guess it won't be affected by the change?

Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please open an issue to document this behaviour, it looks like today we don't explain in the docs where ports on DPP are coming from

@Automaat Automaat merged commit f69014b into kumahq:master Feb 10, 2025
25 checks passed
@Automaat Automaat deleted the feat/inbound-name-from-pod-simple branch February 10, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants