This repository has been archived by the owner on May 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 84
Fix for right-hand-side drawer, and adding toggle button #13
Open
Yuripetusko
wants to merge
16
commits into
ionic-team:master
Choose a base branch
from
Yuripetusko:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: ionic.contrib.drawer.css
@mlynch any chance this can be reviewed and merged soon, I would like to point my bower to main repo rather than my personal one. Thanks |
Could you add some documentation about your directive? |
Thanks @EAndreyF
|
@EAndreyF are you sure you are looking at my code? https://github.com/Yuripetusko/ionic-ion-drawer/blob/master/ionic.contrib.drawer.js |
When you click on opened drawer on left position, it `closes` automatically - moves behind left area.
fix drawer on left position
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2
fixes #5
Codepen here
http://codepen.io/Yuripetusko/pen/VYqRNg