Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Fix for closing problem from the right #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kel-sakal-biyik
Copy link

If you choose to place the drawer to the right by using side attribute, while dragging the drawer to close it, it closes to the left again.

If you choose to place the drawer to the right by using side attribute, while dragging the drawer to close it, it closes to the left again.
@Yuripetusko
Copy link

It works. But not ideally. For example once it is opened if I try to slide it back, it just dissapears instead of transitioning. Also I cannot drag it back.

Have a look at my code. I know it is ugly, I just did a quick fix specific for my case. I need to clean it up and do PR someday. https://github.com/Yuripetusko/ionic-ion-drawer/commits/master

@kel-sakal-biyik
Copy link
Author

Strange. It should go away with transition. I will check again. I will also check yours. Thanks!

@kel-sakal-biyik
Copy link
Author

Here I have created a pen: http://codepen.io/kel-sakal-biyik/pen/QwzGYe

If you decrease the width of the viewport, transition should also work.

@Yuripetusko
Copy link

Hello. I created a PR of my won for the same issue. #13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants