Add checks for Ruby 3.4 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeSouthan
force-pushed
the
joesouthan-ruby-340
branch
from
8fbbd87 to
b2c3a38
Compare
Tabby
reviewed
Feb 5, 2025
Co-authored-by: Tabitha Cromarty <[email protected]>
Tabby
approved these changes
Feb 5, 2025
Tabby
reviewed
Feb 5, 2025
| ruby-version: [3.1, 3.2, 3.3] | ||
| rails-version: [7.0, 7.1, 7.2, 8.0] | ||
| ruby-version: ["3.1", "3.2", "3.3", "3.4"] | ||
| rails-version: ["7.0", "7.1", "7.2", "8.0"] |
There was a problem hiding this comment.
This change means we'll need to update the required checks to match the new check names
There was a problem hiding this comment.
Yep, just getting that sorted 👍
There was a problem hiding this comment.
Should probably remove Ruby 3.1 as a required check as well while you're asking for changes, as that goes EOL in just over a month
There was a problem hiding this comment.
It should stay in the test matrix, just don't think it needs to be a required check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/