Merge pull request #124 from gocardless/joesouthan-ruby-340

Add checks for Ruby 3.4

.github/workflows/test.yml

@@ -2,6 +2,10 @@ name: tests
 
 on:
   push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, reopened, synchronize]
 
 jobs:
   rubocop:
@@ -19,8 +23,8 @@ jobs:
   tests:
     strategy:
       matrix:
-        ruby-version: [3.1, 3.2, 3.3]
-        rails-version: [7.0, 7.1, 7.2, 8.0]
+        ruby-version: ["3.1", "3.2", "3.3", "3.4"]
+        rails-version: ["7.0", "7.1", "7.2", "8.0"]
         exclude:
           - ruby-version: 3.1
             rails-version: 8.0

.rubocop.yml

@@ -1,17 +1,15 @@
 inherit_from: .rubocop_todo.yml
+
 inherit_gem:
   gc_ruboconfig: rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.1
   NewCops: enable
 
 Layout/LineLength:
   Max: 100
 
-Gemspec/DevelopmentDependencies:
-  EnforcedStyle: gemspec
-
 Gemspec/RequiredRubyVersion:
   Enabled: false
 
@@ -20,4 +18,3 @@ RSpec/MultipleExpectations:
 
 RSpec/ExampleLength:
   Max: 15
-

.rubocop_todo.yml

@@ -1,24 +1,29 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-11-11 12:18:14 +0000 using RuboCop version 0.76.0.
+# on 2025-02-05 14:52:30 UTC using RuboCop version 1.71.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-RSpec/LeakyConstantDeclaration:
+# Offense count: 1
+# Configuration parameters: IgnoredMetadata.
+RSpec/DescribeClass:
   Exclude:
-    - 'spec/anony/anonymisable_spec.rb'
-    - 'spec/anony/strategies/overwrite_spec.rb'
+    - '**/spec/features/**/*'
+    - '**/spec/requests/**/*'
+    - '**/spec/routing/**/*'
+    - '**/spec/system/**/*'
+    - '**/spec/views/**/*'
+    - 'spec/anony/rspec_shared_examples_spec.rb'
 
-RSpec/ExampleLength:
+# Offense count: 3
+RSpec/LeakyConstantDeclaration:
   Exclude:
     - 'spec/anony/anonymisable_spec.rb'
+    - 'spec/anony/strategies/overwrite_spec.rb'
 
+# Offense count: 4
+# Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
-  Exclude:
-    - 'spec/anony/anonymisable_spec.rb'
-
-RSpec/DescribeClass:
-  Exclude:
-    - 'spec/anony/rspec_shared_examples_spec.rb'
+  Max: 4

.ruby-version

@@ -1 +1 @@
-3.3.4
+3.4.1

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Add support for Ruby 3.4
+
 ## v1.6.0
 
 - Add support for Rails 8.0

Gemfile

@@ -6,3 +6,13 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in anony.gemspec
 gemspec
+
+group :development, :test do
+  gem "bundler", "~> 2"
+  gem "database_cleaner-active_record", "~> 2.2"
+  gem "gc_ruboconfig", "~> 5.0.0"
+  gem "rspec", "~> 3.9"
+  gem "rspec-github", "~> 3.0.0"
+  gem "sqlite3", "~> 2.5.0"
+  gem "yard", "~> 0.9.20"
+end

anony.gemspec

@@ -24,16 +24,6 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 3.1"
 
-  spec.add_development_dependency "bundler", "~> 2"
-  spec.add_development_dependency "database_cleaner-active_record", "~> 2.2"
-  spec.add_development_dependency "gc_ruboconfig", "~> 5.0.0"
-  spec.add_development_dependency "rspec", "~> 3.9"
-  spec.add_development_dependency "rspec-github", "~> 2.4.0"
-  spec.add_development_dependency "yard", "~> 0.9.20"
-
-  # For integration testing
-  spec.add_development_dependency "sqlite3", "~> 2.4.0"
-
   if ENV["RAILS_VERSION"]
     spec.add_dependency "activerecord", "~> #{ENV['RAILS_VERSION']}"
     spec.add_dependency "activesupport", "~> #{ENV['RAILS_VERSION']}"