Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pharokka to latest version #6651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bgruening
Copy link
Member

@bgruening bgruening commented Dec 28, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

We need some new test database, until then the tests will fail I think.

@bgruening
Copy link
Member Author

@paulzierep do you remember how you have created the test DB?

@gbouras13
Copy link

Hi @bgruening @paulzierep ,

The only major parameter that should be added for the update to the new version (v1.7.4) is --fast. It might also be good to add --prefix and --locustag e.g. for users who may want to submit directly to NCBI/ENA etc.

Another suggestion would be to remove the terminate subunit reorientation option (which is available on v1.3.2) in place of --dnaapler, which is used much more commonly now by users, as it does automatic reorientation.

Otherwise, I think it's all ok - the advanced specific parameters aren't necessary I think for this interface.

George

@gbouras13
Copy link

@bgruening - I made a small dummy test database for Paul back when he installed v1.3.2. I'll do the same now with the latest version.

George

@bgruening
Copy link
Member Author

@gbouras13 having the test database would be absolutely great! Thanks.

@paulzierep
Copy link
Contributor

@gbouras13 can you also provide the latest DB you would like to be used with this version ? Or will install_databases.py -d using this tool version be the one required ?

@gbouras13
Copy link

Hi @paulzierep ,

install_databases.py -d or install_databases.py -o <db_dir> will get the correct database for v1.7.4. You can also find the tarball here if that fails https://zenodo.org/records/8276347 . I'll add a test DB now, sorry for the delay.

George

@gbouras13
Copy link

pharokka_test_db_1.7.4.tar.gz

I've attached the tiny test dummy db like I did for the original v1.3.2 release on galaxy - I've tested it and pharokka v1.7.4 with this locally for me, so should be fine for your purposes.

George

@paulzierep
Copy link
Contributor

paulzierep commented Jan 16, 2025

Here is the updated DM: #6680
@gbouras13 the test dummy db you provided contains a few hidden files, are they needed ?
ls -l ->

.
..
._1Aug2023_data.tsv
1Aug2023_data.tsv
._1Aug2023_genomes.fa.msh
1Aug2023_genomes.fa.msh
all_phrogs.h3m
._aro_index.tsv
aro_index.tsv
._CARD
CARD
._CARD.dbtype
 
...

@gbouras13
Copy link

No sure why they are there (maybe from my MacBook) - definitely don't need any hidden files.

George

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants