Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Add cursor-theme and cursor-theme-size #1539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

settings: Add cursor-theme and cursor-theme-size #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions data/org.freedesktop.portal.Settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@

Unknown values should be treated as ``0`` (no preference).

* ``org.freedesktop.appearance`` ``cursor-theme`` (``s``)

Indicates the system's preferred cursor theme.

* ``org.freedesktop.appearance`` ``cursor-theme-size`` (``u``)

Indicates the system's preferred cursor theme size.
Copy link

@ideasman42 ideasman42 Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to mention if this includes output scaling (how it's expected to handle Hi-DPI / fractional-scaling) for e.g.

Also, if this is an alternative to the XCURSOR_SIZE environment variable which is expected to have identical behavior.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I would assume it be in "logical pixels" like size, meaning equivalent to the surface size one would set with wl_pointer.set_cursor, which is more or less what the existing cursor theme size settings do, and what gsettings get org.gnome.desktop.interface cursor-size would return.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be mentioned in the description then (or a reference elsewhere - to more detailed docs).
On my own desktop I've noticed the cursor size jumping erratically between windows. So having a convention for calculating the final cursor size would be good (including rounding behavior with fractional scaling).
Although that doesn't have to be handled in this PR, failure to define this anywhere likely means cursor size will "jump" from a user perspective.


This documentation describes version 2 of this interface.
-->
<interface name="org.freedesktop.portal.Settings">
Expand Down
Loading