-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: Add cursor-theme and cursor-theme-size #1539
base: main
Are you sure you want to change the base?
Conversation
These aim to provide cursor theming settings that isn't to a desktop environment or toolkit.
|
||
* ``org.freedesktop.appearance`` ``cursor-theme-size`` (``u``) | ||
|
||
Indicates the system's preferred cursor theme size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to mention if this includes output scaling (how it's expected to handle Hi-DPI / fractional-scaling) for e.g.
Also, if this is an alternative to the XCURSOR_SIZE
environment variable which is expected to have identical behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I would assume it be in "logical pixels" like size, meaning equivalent to the surface size one would set with wl_pointer.set_cursor
, which is more or less what the existing cursor theme size settings do, and what gsettings get org.gnome.desktop.interface cursor-size
would return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be mentioned in the description then (or a reference elsewhere - to more detailed docs).
On my own desktop I've noticed the cursor size jumping erratically between windows. So having a convention for calculating the final cursor size would be good (including rounding behavior with fractional scaling).
Although that doesn't have to be handled in this PR, failure to define this anywhere likely means cursor size will "jump" from a user perspective.
Why is this needed? With the Cursor Shape Wayland Protocol the Cursor is drawn by the Compositor, so Apps don't need to know about the Cursor theme. |
The only cursors that must be supported on wayland are surface-based cursors, so they will stick around. |
Applications may need cursors that aren't available as presets in the cursor-shape protocol, in this case there is no unified way to know how large to draw the cursor: Included the mail inline for reference:
|
These aim to provide cursor theming settings that isn't to a desktop environment or toolkit.