Seeds Rework #174 #175
Seeds Rework #174 #175
Conversation
nelsonic
added
the
in-progress
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 24 +1
Lines 539 572 +33
=========================================
+ Hits 539 572 +33
Continue to review full report at Codecov.
|
| @@ -1,9 +1,15 @@ | |||
| export [email protected] | |||
| export AUTH_API_KEY=2PzB7PPnpuLsbWmWtXpGyI+kfSQSQ1zUW2Atz/+8PdZuSEJzHgzGnJWV35nTKRwx/dwylauth.herokuapp.com | |||
| export EMAIL_APP_URL=https://dwylmail.herokuapp.com | |||
| export AUTH_URL=dwylauth.herokuapp.com | |||
There was a problem hiding this comment.
Had to add the AUTH_URL environment variable to avoid the circular dependency on auth_plug noted by @tadasajon in #170
nelsonic
added
awaiting-review
|
@SimonLab please take a look at this PR and LMK what you think. Feedback very much welcome! |
| # to setup the database: | ||
| # | ||
| # mix ecto.setup | ||
| defmodule Auth.Seeds do |
There was a problem hiding this comment.
The bulk of this code moved to init.ex above. ⬆️
nelsonic
added
the
tech-debt
| def main do | ||
| Logger.info("Initialising the Auth Database ...") | ||
| # check required environment variables: | ||
| Envar.is_set_all?(~w/ADMIN_EMAIL AUTH_URL ENCRYPTION_KEYS SECRET_KEY_BASE/) |
There was a problem hiding this comment.
We could create the list of environment variables as a module variable to make it easier to change later on if required. However I think it does the job at the moment
There was a problem hiding this comment.
@SimonLab yeah, that would be a great future enhancement. 👍
Co-authored-by: Simon <[email protected]>
|
@SimonLab thanks very much for reviewing. I've applied your suggested change to |
In order to run the seeds on Fly.io #172 / #173 we needed to move the bulk of the code to
/libthat's what this PR does.I've tried to minimise the changes but had to update a few tests to keep it all 100%. See: #174