Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Deploy Fly.io App issue #172 #173

Merged
merged 81 commits into from
Feb 8, 2022
Merged

PR Deploy Fly.io App issue #172 #173

merged 81 commits into from
Feb 8, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jan 2, 2022

Deploying a fresh version of the auth App to Fly.io for #172

Relevant reading: https://blog.miguelcoba.com/deploying-an-elixir-release-using-docker-on-flyio thanks to @miguelcoba

@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Jan 2, 2022
@nelsonic nelsonic self-assigned this Jan 2, 2022
@nelsonic nelsonic temporarily deployed to dwylauth January 2, 2022 23:48 Inactive
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #173 (1db1f87) into main (ead7450) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        27    +3     
  Lines          572       586   +14     
=========================================
+ Hits           572       586   +14     
Impacted Files Coverage Δ
lib/auth/app.ex 100.00% <ø> (ø)
lib/auth/init/init.ex 100.00% <100.00%> (ø)
lib/auth/init/roles.ex 100.00% <100.00%> (ø)
lib/auth/init/statuses.ex 100.00% <100.00%> (ø)
lib/auth/person.ex 100.00% <100.00%> (ø)
lib/auth/status.ex 100.00% <100.00%> (ø)
lib/auth_web/controllers/init_controller.ex 100.00% <100.00%> (ø)
lib/auth_web/router.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead7450...1db1f87. Read the comment docs.

@nelsonic nelsonic temporarily deployed to dwylauth January 3, 2022 00:01 Inactive
@nelsonic nelsonic added the enhancement New feature or enhancement of existing functionality label Jan 3, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Jan 3, 2022

Created the necessary environment variables:
image

Keep getting interrupted so it's taking a bit longer than it needs to. ⏳

@nelsonic nelsonic temporarily deployed to dwylauth January 3, 2022 02:15 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth January 3, 2022 02:33 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth January 3, 2022 02:44 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth January 3, 2022 03:55 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth February 7, 2022 22:14 Inactive
@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2022

Working: https://auth.dwyl.com/people

image

@nelsonic nelsonic temporarily deployed to dwylauth February 7, 2022 22:36 Inactive
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 7, 2022
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Feb 7, 2022
@nelsonic nelsonic temporarily deployed to dwylauth February 7, 2022 22:49 Inactive
@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2022

@SimonLab apologies for the massive PR. 🙄
I honestly just wanted to deploy to Fly.io ... 🚀
but ended up having to create the init.ex and init_controller.ex in order to achieve the goal. 🎯
Please review and give feedback when you can. 🙏
Once you're happy, please merge.

This is already deployed to https://auth.dwyl.com/ feel free to try and break it! 💭

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments/questions, otherwise LGTM

@nelsonic nelsonic temporarily deployed to dwylauth February 8, 2022 12:43 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth February 8, 2022 12:43 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth February 8, 2022 12:44 Inactive
@nelsonic
Copy link
Member Author

nelsonic commented Feb 8, 2022

Hi @SimonLab 👋 Comments addressed and changes applied. Thanks! ☀️

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the applying the updates @nelsonic . Looks good 👍

@SimonLab SimonLab merged commit 34331e4 into main Feb 8, 2022
@SimonLab SimonLab deleted the deploy-fly-app-issue-#172 branch February 8, 2022 13:56
@nelsonic
Copy link
Member Author

nelsonic commented Feb 8, 2022

Thank you @SimonLab ☀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants