Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Relax unrolling for structs with gc refs #112227

Merged
merged 3 commits into from
Feb 6, 2025
Merged

JIT: Relax unrolling for structs with gc refs #112227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68ef816
Relax unrolling for structs with gc refs
EgorBo Feb 6, 2025
6016d97
Merge branch 'main' into fix-unrolling-for-gc-structs
EgorBo Feb 6, 2025
6a29541
Merge branch 'main' into fix-unrolling-for-gc-structs
EgorBo Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/coreclr/jit/lowerxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,14 +443,15 @@ void Lowering::LowerBlockStore(GenTreeBlk* blkNode)

ClassLayout* layout = blkNode->GetLayout();
bool doCpObj = layout->HasGCPtr();
unsigned copyBlockUnrollLimit = comp->getUnrollThreshold(Compiler::UnrollKind::Memcpy, false);
bool isNotHeap = blkNode->IsAddressNotOnHeap(comp);
bool canUseSimd = !doCpObj || isNotHeap;
unsigned copyBlockUnrollLimit = comp->getUnrollThreshold(Compiler::UnrollKind::Memcpy, canUseSimd);

#ifndef JIT32_GCENCODER
if (doCpObj && (size <= copyBlockUnrollLimit))
{
// No write barriers are needed on the stack.
// If the layout is byref-like, then we know it must live on the stack.
if (blkNode->IsAddressNotOnHeap(comp))
// No write barriers are needed if the destination is known to be outside of the GC heap.
if (isNotHeap)
{
// If the size is small enough to unroll then we need to mark the block as non-interruptible
// to actually allow unrolling. The generated code does not report GC references loaded in the
Expand Down Expand Up @@ -515,7 +516,7 @@ void Lowering::LowerBlockStore(GenTreeBlk* blkNode)
}
}
else if (blkNode->OperIs(GT_STORE_BLK) &&
(size <= comp->getUnrollThreshold(Compiler::UnrollKind::Memcpy, !layout->HasGCPtr())))
(size <= comp->getUnrollThreshold(Compiler::UnrollKind::Memcpy, canUseSimd)))
{
blkNode->gtBlkOpKind = GenTreeBlk::BlkOpKindUnroll;

Expand Down
Loading