JIT: Relax unrolling for structs with gc refs #112227
Merged
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we need to copy a block with GC references (from anywhere to non-heap), we can actually use SIMD if we put the whole copy part under no-GC - this is valid because nobody else is expected to read it from stack in parallel (it's UB). The existing code is a bit conservative in that regard, it only allows blocks <= 64 bytes (and avoids SIMD in favor of slow
rep movsq
or bulk write barrier).This is primary needed to address possible performance regressions #112060 may introduce, but it should be a goodness regardless whether that PR lands or not.
NOTE: arm64 has a similar logic already.
Example (I use ref structs here, but it works for regular structs as well):
Main:
PR: