-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: change SacRT copy to say "bus" instead of "light rail" #2507
Conversation
Hmm, I'm not sure why the Django migration+messages check is failing... I did run edit: also when I run the commands that the workflow is running, I get the output that should make the workflow pass.
gives me
|
The translations look great @angela-tran! |
~~never mind~~I think this is due to how GitHub pull requests are technically running on a hidden branch that compares the base and target branches.I am able to reproduce the failing check locally with these steps:
./bin/makemessages.sh
set -x # show commands
git add benefits
# message files are up-to-date if the only differences are from the updated timestamp
if echo $(git diff --cached --shortstat) | grep -q '2 files changed, 2 insertions(+), 2 deletions(-)';
then
exit 0;
else
exit 1;
fi
My output
These sources confirm that there is a "hidden branch" or whatever it is
|
their plan is to roll out the new system on buses first. for the Spanish translations, I did my best to map "bus" in based on the copy for SBMTD.
ebeb121
to
085391e
Compare
Ok, never mind. I'm not sure what state I was in before, but I just re-checked out Committed those, and the check should pass now. I don't think it had anything to do with the special |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Part of #2505
There were 3 places I found that mentioned "light rail":
charged a reduced fare. You will need to re-enroll if you choose to change the card you use to pay for transit service." - enrollment success
For the Spanish translations, I did my best to map "bus" in for SacRT based on the copy for SBMTD. @lalver1 Maybe you can check my work to see if it makes sense to a Spanish speaker?
SBMTD entries in
es/LC_MESSAGES/django.po
are right below SacRT's entries, so you can compare them pretty easily.