Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: configure SBMTD senior flow #1631

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Feat: configure SBMTD senior flow #1631

merged 7 commits into from
Aug 15, 2023

Conversation

angela-tran
Copy link
Member

Closes #1588

@angela-tran angela-tran added this to the SBMTD milestone Aug 9, 2023
@angela-tran angela-tran self-assigned this Aug 9, 2023
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Aug 9, 2023
@angela-tran
Copy link
Member Author

Waiting on #1632 to be merged before we can add the SBMTD logo

@angela-tran angela-tran mentioned this pull request Aug 9, 2023
Merged
This was referenced Aug 10, 2023
Closed
Closed
@angela-tran
Copy link
Member Author

@angela-tran angela-tran marked this pull request as ready for review August 11, 2023 17:16
@angela-tran angela-tran requested a review from a team as a code owner August 11, 2023 17:16
@angela-tran
Copy link
Member Author

Ready for review

machikoyasuda
machikoyasuda previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed index, agency index, agency selector modal logos, help page/contact info, elig index 👍

thekaveman
thekaveman requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "officially" submitting my feedback as a Review 😉

#1631 (comment)

@angela-tran
Copy link
Member Author

  • Added SBMTD PaymentProcessor to data migration
  • Added copy and translations to templates and .PO files
  • Added secrets to dev Key Vault

When I try to run through the flow locally, I get a 403 error from the payment processor window, so that will be something to resolve outside of this PR.

@angela-tran
Copy link
Member Author

Oops, I forgot to define and set the other SBMTD secrets (the non-payment processor ones). Putting back into draft

@angela-tran angela-tran marked this pull request as draft August 14, 2023 22:24
@angela-tran
Copy link
Member Author

Finished adding SBMTD secrets to dev Key Vault

@angela-tran angela-tran marked this pull request as ready for review August 14, 2023 22:35
thekaveman
thekaveman approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@angela-tran angela-tran merged commit b251c74 into dev Aug 15, 2023
10 checks passed
@angela-tran angela-tran deleted the feat/sbmtd-senior-config branch August 15, 2023 01:39
@angela-tran angela-tran mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
SBMTD Older Adults
Development

Successfully merging this pull request may close these issues.

Create app configuration for SBMTD+Senior
3 participants
@angela-tran @thekaveman @machikoyasuda