Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish copy + small copy fixes #1629

Merged
merged 23 commits into from
Aug 11, 2023
Merged

Spanish copy + small copy fixes #1629

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cc6bb56
feat(copy): add Spanish copy
machikoyasuda Aug 9, 2023
7bff521
fix: add back issues link
machikoyasuda Aug 9, 2023
cdbec01
fix(help): correct mst cc q/a on help
machikoyasuda Aug 9, 2023
0dfae40
fix(titles): change back Overview to Information
machikoyasuda Aug 9, 2023
0932209
fix(copy): add new Page TItles
machikoyasuda Aug 9, 2023
ec94d48
fix(enrollment): fix lp link misplaced
machikoyasuda Aug 9, 2023
abc79b3
fix(copy): switch around titles
machikoyasuda Aug 9, 2023
424161b
fix(copy): fix page titles for elig/start - use Overview
machikoyasuda Aug 9, 2023
937fc07
fix: update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 9, 2023
1362fdb
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 9, 2023
d977889
fix: Update benefits/locale/en/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
8e82450
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
a0db4e7
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
6ed89e7
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
91b7081
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
83eba05
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
8a19a0e
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
947a439
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
8e3f04c
fix(copy): fix VeteranS everywhere
machikoyasuda Aug 10, 2023
2dfb7fe
fix(copy): : Agency card overview / Descripción de la tarjeta de agencia
machikoyasuda Aug 10, 2023
d33a410
fix(sp): don't title case any buttons in Spanish
machikoyasuda Aug 10, 2023
1335e2c
fix(copy): Courtesy card -> Agency card
machikoyasuda Aug 10, 2023
3843ff5
fix(copy): We couldn't connect your card
machikoyasuda Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benefits/core/migrations/0002_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def load_data(app, *args, **kwargs):
form_sub_pattern=r"\d{5}",
form_input_mode="numeric",
form_max_length=5,
form_name_label=_("last name (as it appears on Courtesy Card)"),
form_name_label=_("Last name (as it appears on Courtesy Card)"),
form_name_help_text=_("We use this to help confirm your Courtesy Card."),
form_name_placeholder="Garcia",
form_name_max_length=255,
Expand Down
2 changes: 1 addition & 1 deletion benefits/eligibility/templates/eligibility/start--mst-courtesy-card.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load i18n %}

{% block page-title %}
{% translate "Courtesy Card information" %}
{% translate "Courtesy Card overview" %}
machikoyasuda marked this conversation as resolved.
Show resolved Hide resolved
{% endblock page-title %}

{% block headline %}
Expand Down
2 changes: 1 addition & 1 deletion benefits/eligibility/templates/eligibility/start--senior.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load i18n %}

{% block page-title %}
{% translate "Older Adult benefit information" %}
{% translate "Older Adult benefit overview" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match casing from the spreadsheet

Suggested change
{% translate "Older Adult benefit overview" %}
{% translate "Older adult benefit overview" %}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indexing @srhhnry Question - Should Older Adult be capitalized in the title? It's capitalized on the form and headline:

image image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srhhnry Stylistically, do we consider all benefit types proper names? I think we do. If so, I would capitalize both words (Older Adult). If not, I would use sentence case (Older adult) and other references in-line would be "older adult."

Once you've confirmed, I will review the spreadsheet to ensure consistency. (cc// @angela-tran )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion:

  • Older Adult should be title-cased in English (b/c we already introduce this precedent in the app) and sentence-cased in Spanish (nothing is ever title-cased or capitalized in Spanish unless it starts the sentence/phrase). We're only using Older Adult because that is the politically-correct way to say Senior.

  • Agency card can be sentence-cased in English.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion is the same as Machiko's ^

{% endblock page-title %}

{% block headline %}
Expand Down
2 changes: 1 addition & 1 deletion benefits/eligibility/templates/eligibility/start--veteran.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load i18n %}

{% block page-title %}
{% translate "Veteran benefit information" %}
{% translate "Veteran benefit overview" %}
{% endblock page-title %}

{% block headline %}
Expand Down
16 changes: 8 additions & 8 deletions benefits/locale/en/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#, fuzzy
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: https://github.com/cal-itp/benefits/issues \n"
"POT-Creation-Date: 2023-08-08 22:20+0000\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-08-09 19:35+0000\n"
"Language: English\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand All @@ -30,7 +30,7 @@ msgstr ""
msgid "This is a 5-digit number on the front and back of your card."
msgstr ""

msgid "last name (as it appears on Courtesy Card)"
msgid "Last name (as it appears on Courtesy Card)"
msgstr ""

msgid "We use this to help confirm your Courtesy Card."
Expand Down Expand Up @@ -407,8 +407,8 @@ msgid ""
"This option is for people who have served in the active military, naval, or "
"air service, and who were discharged or released therefrom under conditions "
"other than dishonorable. You will need to <a href=\"https://www.va.gov/"
"resources/verifying-your-identity-on-vagov/\" target=\"_blank\" "
"rel=\"noopener noreferrer\">verify your identity through VA.gov</a>."
"resources/verifying-your-identity-on-vagov/\" target=\"_blank\" rel="
"\"noopener noreferrer\">verify your identity through VA.gov</a>."
msgstr ""

#, python-format
Expand All @@ -429,7 +429,7 @@ msgstr ""
msgid "Choose the transit benefit you would like to enroll in"
msgstr ""

msgid "Courtesy Card information"
msgid "Courtesy Card overview"
msgstr ""

msgid "You selected a Courtesy Card transit benefit."
Expand All @@ -438,7 +438,7 @@ msgstr ""
msgid "Continue"
msgstr ""

msgid "Older Adult benefit information"
msgid "Older Adult benefit overview"
machikoyasuda marked this conversation as resolved.
Show resolved Hide resolved
msgstr ""

msgid "You selected an Older Adult transit benefit."
Expand All @@ -447,7 +447,7 @@ msgstr ""
msgid "Get started with"
msgstr ""

msgid "Veteran benefit information"
msgid "Veteran benefit overview"
msgstr ""

msgid "You selected a Veteran transit benefit."
Expand Down
Loading
Loading