Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish copy + small copy fixes #1629

Merged
merged 23 commits into from
Aug 11, 2023
Merged

Spanish copy + small copy fixes #1629

merged 23 commits into from
Aug 11, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 9, 2023

fixes #1572
fixes #1628
closes #1410
closes #1630

What this PR does

Translation notes

  • The name of the app in Spanish is now Cal-ITP Benefits. It's a singular noun. It's not los Beneficios de Cal-ITP (plural) anymore.
  • California Integrated Travel Project is Proyecto Integrado de Viaje de California
  • We had a typo all along.... eligibilidad is not a word in Spanish. It's elegibilidad.
  • The translation of Courtesy Card is not capitalized.
  • There's no Spanish-language link for the VA.gov link https://www.va.gov/resources/verifying-your-identity-on-vagov/

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 9, 2023
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates labels Aug 9, 2023
@machikoyasuda machikoyasuda self-assigned this Aug 9, 2023
@github-actions github-actions bot added the i18n Copy: Language files or Django i18n framework label Aug 9, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 9, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review August 9, 2023 20:44
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 9, 2023 20:44
@machikoyasuda
Copy link
Member Author

Ready for review @angela-tran

@machikoyasuda
Copy link
Member Author

@angela-tran JK actually changing ONE LAST THING

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Aug 9, 2023

@angela-tran Now truly ready for review.

https://docs.google.com/spreadsheets/d/1_Gi_YbJr4ZuXCOsnOWaewvHqUO1nC1nKqiVDHvw0118/edit#gid=0

image
  • New English Page titles come from EN-US tab
  • Spanish translations come from forTranslation and All Agencies tab

@angela-tran
Copy link
Member

Reviewing this now 👀

@@ -2,7 +2,7 @@
{% load i18n %}

{% block page-title %}
{% translate "Older Adult benefit information" %}
{% translate "Older Adult benefit overview" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match casing from the spreadsheet

Suggested change
{% translate "Older Adult benefit overview" %}
{% translate "Older adult benefit overview" %}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indexing @srhhnry Question - Should Older Adult be capitalized in the title? It's capitalized on the form and headline:

image image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srhhnry Stylistically, do we consider all benefit types proper names? I think we do. If so, I would capitalize both words (Older Adult). If not, I would use sentence case (Older adult) and other references in-line would be "older adult."

Once you've confirmed, I will review the spreadsheet to ensure consistency. (cc// @angela-tran )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion:

  • Older Adult should be title-cased in English (b/c we already introduce this precedent in the app) and sentence-cased in Spanish (nothing is ever title-cased or capitalized in Spanish unless it starts the sentence/phrase). We're only using Older Adult because that is the politically-correct way to say Senior.

  • Agency card can be sentence-cased in English.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion is the same as Machiko's ^

benefits/locale/en/LC_MESSAGES/django.po Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
"Si necesita ayuda con este sitio web, póngase en contacto con el equipo de "
"servicio al cliente de su proveedor de transito local."
"Si necesita ayuda con este sitio web, comuníquese con el equipo de atención "
"al cliente de su proveedor de transito local."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find this in the spreadsheet. There is only
If you need help with this website, please reach out to the CST customer service team. ->
Si necesita ayuda con este sitio web, comuníquese con el equipo de atención al cliente de California State Transit. (row 34, forTranslation sheet).

Maybe we use short_name in place of CST?

Copy link
Member Author

@machikoyasuda machikoyasuda Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I think this is b/c of a limitation of Figma:

  • The Figma design for the Help page only has 1 Help page. But there is 1 Help page for all agencies, and 1 Help page for each agency... so in a 2 agency scenario, there are 3 Help pages. But all 3 are not on Figma.
  • And the Google Spreadsheet is largely based on what's on Figma. So the Google Spreadsheet also does not reflect the fact that there are 3 Help pages with mostly the same copy, but some different copy.

Here's what's on Test:
https://test-benefits.calitp.org/help (Don't click an agency)
image

When I click MST and then click Help, I still get this generic sentence, that then leads me to contact info:
image

So I don't think this copy is used anywhere even though it's on the spreadsheet:
image
https://share.getcloudapp.com/8LuYkA0P?collection_id=nlfk4Q0
image

Therefore, I think for this issue, we should change the Google Spreadsheet (and sync'd to Figma as well) to have this generic (agency-less) sentence:

If you need assistance with this website, please reach out to the customer service team for your local transit provider.
Si necesita ayuda con este sitio web, comuníquese con el equipo de atención al cliente de su proveedor de transito local.

@indexing thoughts?

benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@angela-tran
Copy link
Member

@machikoyasuda I've finished reviewing. Thanks for all your work on this!

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@machikoyasuda
Copy link
Member Author

Summary of changes since review:

  • Fix English in 3 places: "We couldn’t connect your bank card" -> "We couldn’t connect your card"
  • Fix Spanish: fix SacRT Spanish copy that had MST instead
  • Fix Spanish: remove unnecessary ’s
  • Fix Spanish: grande not pequeño
  • Fix Spanish: Remove * from form, 2 places
  • Fix English in 3 places: Veterans not Veteran
  • Fix English in 3 places: Agency card overview not Courtesy Card overview
  • Fix Spanish: Elegir este beneficio (Don't title-case any buttons in Spanish).
  • Fix English in 3 places: Agency card information not Courtesy Card information

Not changed:

Ready for re-review @indexing @angela-tran

@machikoyasuda machikoyasuda merged commit 25a9f4d into dev Aug 11, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the feat/1572-spanish branch August 11, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
3 participants