-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish copy + small copy fixes #1629
Conversation
Ready for review @angela-tran |
@angela-tran JK actually changing ONE LAST THING |
@angela-tran Now truly ready for review. https://docs.google.com/spreadsheets/d/1_Gi_YbJr4ZuXCOsnOWaewvHqUO1nC1nKqiVDHvw0118/edit#gid=0
|
Reviewing this now 👀 |
benefits/eligibility/templates/eligibility/start--mst-courtesy-card.html
Outdated
Show resolved
Hide resolved
@@ -2,7 +2,7 @@ | |||
{% load i18n %} | |||
|
|||
{% block page-title %} | |||
{% translate "Older Adult benefit information" %} | |||
{% translate "Older Adult benefit overview" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match casing from the spreadsheet
{% translate "Older Adult benefit overview" %} | |
{% translate "Older adult benefit overview" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srhhnry Stylistically, do we consider all benefit types proper names? I think we do. If so, I would capitalize both words (Older Adult). If not, I would use sentence case (Older adult) and other references in-line would be "older adult."
Once you've confirmed, I will review the spreadsheet to ensure consistency. (cc// @angela-tran )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion:
-
Older Adult
should be title-cased in English (b/c we already introduce this precedent in the app) and sentence-cased in Spanish (nothing is ever title-cased or capitalized in Spanish unless it starts the sentence/phrase). We're only usingOlder Adult
because that is the politically-correct way to saySenior
. -
Agency card
can be sentence-cased in English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion is the same as Machiko's ^
"Si necesita ayuda con este sitio web, póngase en contacto con el equipo de " | ||
"servicio al cliente de su proveedor de transito local." | ||
"Si necesita ayuda con este sitio web, comuníquese con el equipo de atención " | ||
"al cliente de su proveedor de transito local." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find this in the spreadsheet. There is only
If you need help with this website, please reach out to the CST customer service team.
->
Si necesita ayuda con este sitio web, comuníquese con el equipo de atención al cliente de California State Transit.
(row 34, forTranslation
sheet).
Maybe we use short_name
in place of CST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I think this is b/c of a limitation of Figma:
- The Figma design for the Help page only has 1 Help page. But there is 1 Help page for all agencies, and 1 Help page for each agency... so in a 2 agency scenario, there are 3 Help pages. But all 3 are not on Figma.
- And the Google Spreadsheet is largely based on what's on Figma. So the Google Spreadsheet also does not reflect the fact that there are 3 Help pages with mostly the same copy, but some different copy.
Here's what's on Test:
https://test-benefits.calitp.org/help (Don't click an agency)
When I click MST and then click Help, I still get this generic sentence, that then leads me to contact info:
So I don't think this copy is used anywhere even though it's on the spreadsheet:
https://share.getcloudapp.com/8LuYkA0P?collection_id=nlfk4Q0
Therefore, I think for this issue, we should change the Google Spreadsheet (and sync'd to Figma as well) to have this generic (agency-less) sentence:
If you need assistance with this website, please reach out to the customer service team for your local transit provider.
Si necesita ayuda con este sitio web, comuníquese con el equipo de atención al cliente de su proveedor de transito local.
@indexing thoughts?
@machikoyasuda I've finished reviewing. Thanks for all your work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
Summary of changes since review:
Not changed:
Ready for re-review @indexing @angela-tran |
fixes #1572
fixes #1628
closes #1410
closes #1630
What this PR does
information
foroverview
on Elig Start)Translation notes
Cal-ITP Benefits
. It's a singular noun. It's notlos Beneficios de Cal-ITP
(plural) anymore.California Integrated Travel Project
isProyecto Integrado de Viaje de California
eligibilidad
is not a word in Spanish. It'selegibilidad
.