Update endpoint IP selection order based on address type found #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Ganesh <[email protected]>
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, we set the etcd endpoint based on the address set on machine status and give preference to InternalIP/DNS over externalIP/DNS. CAPV introduced a change in which they set the machine address of type InternalIP to be the vm name. This breaks the endpoint check logic we currently have as we would not have a DNS entry for the corresponding endpoint. In this change, we record all the address types found in the machine status and take a precedence based approach in which DNS entries take precedence over IPs and external type takes precedence over internal. We are excluding HostName address type as it would again fail in our connection check.
Testing:
Built the controller and tested manually to be able to create clusters with CAPV 1.9.3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.