Update external etcd patch to use the right address type #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Ganesh <[email protected]>
Signed-off-by: Rahul Ganesh <[email protected]>
eks-distro-bot
added
the
size/M
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
CAPV introduced a new change in
v1.9.xwhere they set the internalIP address type to the host name. This broke how our etcd endpoint used to select IP for it's endpoint as we were picking the host name now instead of the actual IP. This fix set the right address type on the etcd machine. However, our CAPI patch has a similar logic for selecting the IP to do aetcdadm join ...to join the bootsrapped etcd cluster. So whenever the other etcd peers are trying to join an existing etcdcluster the join command fails as it is using the host-name instead of actual IP. Fix the logic in our external etcd support patch on CAPI to actually look for all address types set on the machine and use the same precedence that's being used by the etcdadm-controller.Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.