Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feather_m4_can board, add mcan example #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add feather_m4_can board, add mcan example #681

wants to merge 1 commit into from

Conversation

Felix-El
Copy link

@Felix-El Felix-El commented Apr 27, 2023 •
edited
Loading

Summary

  • The board is added as a clone of feather_m4 with chip changed ATSAM(D->E)51J
  • Adapt pinmux: alternate function pins for CAN1 connecting to TCAN1051 transceiver
  • Clone mcan example from atsame54_xpro board (using periodic task instead of button)

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json

@Felix-El Felix-El force-pushed the master branch 6 times, most recently from 38cd384 to 66a2feb Compare May 2, 2023 14:06
@jbeaurivage jbeaurivage added the board support Related to support for a particular board label May 14, 2023
@Felix-El Felix-El force-pushed the master branch 4 times, most recently from 2faa754 to b5826ed Compare May 16, 2023 08:57
@Felix-El
Add feather_m4_can board, add mcan example
df032cb 
- the new `feather_m4_can` board is added as a clone
  of `feather_m4` with the chip changed ATSAM(D->E)51J

- apply changes in board layout from `Feather M4`
  - adapt pinmux: alternate function pins for CAN1 connecting
    to TCAN1051 transceiver (RX, TX, S) and BOOST_EN
  - add aref pin on PA03
  - move battery pin from PB01 to PB00
  - Neopixel: update data to be on PB02, add enable pin PB03

- add neopixel rainbow example
- adapt `mcan` example from `xplain` board replacing
  button triggering by a periodic task
sajattack
sajattack requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@sajattack sajattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to #658 and I believe the same comments apply to your attempt. #622 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajattack sajattack sajattack requested changes

Assignees
No one assigned
Labels
board support Related to support for a particular board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Felix-El @sajattack @jbeaurivage