Remove backcompat code for stackdriver #36442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
full tests needed
boring-cyborg
bot
added
area:logging
area:providers
provider:google
This was referenced Dec 27, 2023
potiuk
force-pushed
the
remove-backcompat-stackdriver-code
branch
from
7a3ba7e
to
6462d32
Compare
|
Well. I am puzzled ... It seem the previously seen |
There more you look on the flakey error the less chance that it appear again 🤣 |
Very much so: 🐻 |
|
Seems like main started to fail after merging the other PR - let's see if #36453 will fix it again. |
potiuk
force-pushed
the
remove-backcompat-stackdriver-code
branch
from
6462d32
to
55b9fe9
Compare
Remove back-compatibility code for stackdriver now that we are at >= 2.6.0. This caused problems recently with flaky / leaking tests but hopefully apache#36455 fixed the triggering mechanism for that flaky test and this one should succeed now.
potiuk
force-pushed
the
remove-backcompat-stackdriver-code
branch
from
55b9fe9
to
3d9ff56
Compare
potiuk
changed the title
|
Right - we should be able to merge that one now after @Taragolis improved log filtering. |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove back-compatibility code for stackdriver now that we are
at >= 2.6.0.
This caused problems recently with flaky / leaking tests but
hopefully #36455 fixed the triggering mechanism for that flaky
test and this one should succeed now.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.