Remove remaining Airflow 2.5 backcompat code from GCS Task Handler #36443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
provider:google
potiuk
added
the
full tests needed
|
This one is the same code as in the code reverted in #36440 (reverting #36366) - but only limited to GCS Task Handler backcompat (stackdriver removal is separated to #36442. This will allow to test the hypothesis that the error in tests we saw is caused by asyncio tests for Stackdriver handlers leaking asyncio tasks to other tests (likely manifestation of pytest-dev/pytest-asyncio#200) |
Taragolis
approved these changes
Dec 27, 2023
hussein-awala
approved these changes
Dec 27, 2023
|
Looks like both split PRs are green :( I will merge this one as less likely to be the reason and rebase the #36442 - maybe the "combo" causes it. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 27, 2023
…ndler (apache#36443)" This reverts commit 75faf11.
potiuk
added a commit
that referenced
this pull request
Dec 27, 2023
…36443) Co-authored-by: Andrey Anshin <[email protected]> (cherry picked from commit 75faf11)
potiuk
added a commit
that referenced
this pull request
Dec 27, 2023
…36443) (#36457) Co-authored-by: Andrey Anshin <[email protected]> (cherry picked from commit 75faf11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.