Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Ansible Builder Errors for Podman on Windows #717

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Resolve Ansible Builder Errors for Podman on Windows #717

wants to merge 3 commits into from

Commits on Oct 31, 2024

  1. fix: include chmod flag during file copy 

    This fixes an issue for Podman on Windows, which copies over executable
files without the executable bit on, which causes subsequent
Containerfile steps to fail.

By explicitly marking copied files as executable, this issue is
remedied, and Ansible Builder is made usable on more platforms.
    @kevinshurtz
    kevinshurtz committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3d9c61e View commit details
    Browse the repository at this point in the history

  2. fix: use posix path for entrypoint 

    Since Containerfiles use a POSIX-like syntax, and I don't believe that
Windows containers are supported base images, I think it's safe to say
that Windows hosts should not insert backslash characters into
entrypoint path for their Containerfiles.
    @kevinshurtz
    kevinshurtz committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    278f908 View commit details
    Browse the repository at this point in the history

  3. test: add unit test for posix path separator 

    This adds a unit test to make sure that when Windows NT path separator
characters are preferred by os.path, the entrypoint will still be
defined with POSIX path separators.
    @kevinshurtz
    kevinshurtz committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fa672cc View commit details
    Browse the repository at this point in the history